-
Notifications
You must be signed in to change notification settings - Fork 3
Array resolution #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Array resolution #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meerkat-core/src/get-wrapped-base-query-with-projections/sql-expression-modifiers.ts
Outdated
Show resolved
Hide resolved
meerkat-node/src/cube-to-sql-with-resolution/cube-to-sql-with-resolution.ts
Outdated
Show resolved
Hide resolved
meerkat-node/src/cube-to-sql-with-resolution/cube-to-sql-with-resolution.ts
Outdated
Show resolved
Hide resolved
meerkat-node/src/cube-to-sql-with-resolution/cube-to-sql-with-resolution.ts
Outdated
Show resolved
Hide resolved
meerkat-node/src/cube-to-sql-with-resolution/steps/aggregation-step.ts
Outdated
Show resolved
Hide resolved
meerkat-core/src/resolution/generators/generate-row-number-sql.ts
Outdated
Show resolved
Hide resolved
zaidjan-devrev
approved these changes
Nov 12, 2025
vpbs2
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.devrev.ai/devrev/works/ISS-219002
This PR adds support for resolving array fields which was not added before.
Note: We are going to get array fields only in a table visualization. It is not going to come in any other visualization.
In the resolution config, added a new field isArrayType which indicates if the field is an array type or not. If there is atleast one array resolution field, we go through a new flow using the below steps
What is not guaranteed:
What is guaranteed:
Test Cases Verified: